From a2a560d4e5a126425a65ff50d60d5e97f46b1826 Mon Sep 17 00:00:00 2001
From: Andrey Kutejko <andy128k@gmail.com>
Date: Sat, 10 Aug 2013 17:40:55 +0300
Subject: [PATCH] simplify widget creation

---
 ipf/form/field.php         | 24 ++++++------------------
 ipf/form/field/html.php    | 10 +++++-----
 ipf/form/field/varchar.php | 19 ++++++++-----------
 3 files changed, 19 insertions(+), 34 deletions(-)

diff --git a/ipf/form/field.php b/ipf/form/field.php
index 46dbcdf..bd87d67 100644
--- a/ipf/form/field.php
+++ b/ipf/form/field.php
@@ -28,18 +28,9 @@ class IPF_Form_Field
             if ($key !== 'widget_attrs')
                 $this->$key = $m[$key];
         }
-        $widget_name = $this->getWidget();
-        if (isset($params['widget_attrs'])) {
-            $attrs = $params['widget_attrs'];
-        } else {
-            $attrs = array();
-        }
-        $widget = new $widget_name($attrs);
-        $attrs = $this->widgetAttrs($widget);
-        if (count($attrs)) {
-            $widget->attrs = array_merge($widget->attrs, $attrs);
-        }
-        $this->widget = $widget;
+
+        $widget_attrs = isset($params['widget_attrs']) ? $params['widget_attrs'] : array();
+        $this->widget = $this->createWidget($widget_attrs);
     }
 
     public function clean($value)
@@ -53,13 +44,10 @@ class IPF_Form_Field
     function LateClean($data, &$cleaned_data){
     }
 
-    protected function getWidget(){
-        return $this->widget;
-    }
-
-    public function widgetAttrs($widget)
+    protected function createWidget($args)
     {
-        return array();
+        $widgetClass = $this->widget;
+        return new $widgetClass($args);
     }
 }
 
diff --git a/ipf/form/field/html.php b/ipf/form/field/html.php
index ed985e8..6c44320 100644
--- a/ipf/form/field/html.php
+++ b/ipf/form/field/html.php
@@ -1,7 +1,7 @@
 <?php
 
-class IPF_Form_Field_Html extends IPF_Form_Field_Varchar{
-    protected function getWidget(){
-        return 'IPF_Form_Widget_HTMLInput';
-    }
-}
\ No newline at end of file
+class IPF_Form_Field_Html extends IPF_Form_Field_Varchar
+{
+    public $widget = 'IPF_Form_Widget_HTMLInput';
+}
+
diff --git a/ipf/form/field/varchar.php b/ipf/form/field/varchar.php
index 6946d95..804576a 100644
--- a/ipf/form/field/varchar.php
+++ b/ipf/form/field/varchar.php
@@ -22,19 +22,16 @@ class IPF_Form_Field_Varchar extends IPF_Form_Field
         return $value;
     }
 
-    public function widgetAttrs($widget)
+    protected function createWidget($args)
     {
-        if ($this->max_length !== null and in_array(get_class($widget), array('IPF_Form_Widget_TextInput', 'IPF_Form_Widget_PasswordInput'))) {
-            return array('maxlength'=>$this->max_length);
+        if ($this->max_length > 255) {
+            $widgetClass = 'IPF_Form_Widget_TextareaInput';
+        } else {
+            $widgetClass = $this->widget;
+            if ($this->max_length !== null)
+                $args['maxlength'] = $this->max_length;
         }
-        return array();
-    }
-    
-    protected function getWidget()
-    {
-        if ($this->max_length>255)
-            return 'IPF_Form_Widget_TextareaInput';
-        return $this->widget;
+        return new $widgetClass($args);
     }
 }
 
-- 
2.49.0