From 7ed9be89e53246441d6433f1af38c5bbb10809c8 Mon Sep 17 00:00:00 2001 From: Andrey Kutejko Date: Fri, 26 Dec 2014 00:34:57 +0200 Subject: [PATCH] no static methods in auth app --- ipf/admin/app.php | 2 +- ipf/auth/admin.php | 8 ++++---- ipf/auth/app.php | 10 +++++----- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/ipf/admin/app.php b/ipf/admin/app.php index 976aba0..815555e 100644 --- a/ipf/admin/app.php +++ b/ipf/admin/app.php @@ -109,7 +109,7 @@ class IPF_Admin_App extends IPF_Application if (count(array_diff($requiredPermissions, $component->getPerms($request)))) return false; - if ($request->user->is_superuser || !\IPF_Auth_App::ArePermissionsEnabled()) + if ($request->user->is_superuser || !\PFF\Container::auth()->arePermissionsEnabled()) return true; $authPermissions = F::bind('array_map', diff --git a/ipf/auth/admin.php b/ipf/auth/admin.php index 87b9c5a..a0c39b1 100644 --- a/ipf/auth/admin.php +++ b/ipf/auth/admin.php @@ -89,7 +89,7 @@ class UserForm extends \IPF_ObjectForm } $permissions = array('is_active', 'is_staff', 'is_superuser'); - if (\IPF_Auth_App::ArePermissionsEnabled()) { + if (\PFF\Container::auth()->arePermissionsEnabled()) { $permissions[] = 'permissions'; $permissions[] = 'roles'; @@ -165,7 +165,7 @@ class AdminUser extends \IPF_Admin_Component 'is_staff', 'is_superuser', ); - if (\IPF_Auth_App::ArePermissionsEnabled()) { + if ($this->auth_app->arePermissionsEnabled()) { $columns[] = 'groups'; } return $columns; @@ -266,7 +266,7 @@ class RoleForm extends \IPF_ObjectForm 'max_length' => 255, )); - if (\IPF_Auth_App::ArePermissionsEnabled()) { + if (\PFF\Container::auth()->arePermissionsEnabled()) { $this->fields['permissions'] = new \IPF_Form_Field_MultipleChoice(array( 'label' => __('Permissions'), 'choices' => permissionChoices(), @@ -356,7 +356,7 @@ class AdminRole extends \IPF_Admin_Component public function slug() { return 'role'; } } -if (\IPF_Auth_App::ArePermissionsEnabled()) { +if (\PFF\Container::auth()->arePermissionsEnabled()) { return array( 'IPF\Auth\Admin\AdminUser', 'IPF\Auth\Admin\AdminRole', diff --git a/ipf/auth/app.php b/ipf/auth/app.php index 4626c1e..f4121b3 100644 --- a/ipf/auth/app.php +++ b/ipf/auth/app.php @@ -55,16 +55,16 @@ class IPF_Auth_App extends IPF_Application ); } - private static $permissionsEnabled = null; + private $permissionsEnabled = null; - static function ArePermissionsEnabled() + function arePermissionsEnabled() { - if (self::$permissionsEnabled === null) - self::$permissionsEnabled = (bool)\PFF\Container::databaseQuery() + if ($this->permissionsEnabled === null) + $this->permissionsEnabled = (bool)\PFF\Container::databaseQuery() ->from('auth_permission') ->select('COUNT(1)') ->fetchColumn(); - return self::$permissionsEnabled; + return $this->permissionsEnabled; } public function commands() -- 2.49.0