From 52f3ada403ed25d639f790c3eadd2fb4d5e82443 Mon Sep 17 00:00:00 2001 From: Andrey Kutejko Date: Wed, 3 Sep 2014 03:33:03 +0300 Subject: [PATCH] cleanup --- ipf/admin/static/admin/css/forms.css | 2 +- ipf/admin/templates/admin/items.html | 2 +- ipf/form/widget/selectinput.php | 10 ++++------ 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/ipf/admin/static/admin/css/forms.css b/ipf/admin/static/admin/css/forms.css index 7d46add..934da57 100644 --- a/ipf/admin/static/admin/css/forms.css +++ b/ipf/admin/static/admin/css/forms.css @@ -111,7 +111,7 @@ ul.orderer li.deleted:hover, ul.orderer li.deleted a.selector:hover { cursor:def /* FORM ROWS */ .form-row { overflow:hidden; padding:8px 12px; font-size:11px; border-bottom:1px solid #eee; } .form-row img { vertical-align:middle; } -.form-row input { vertical-align:middle; width: 300px; } +.form-row input[type=text] { vertical-align:middle; width: 300px; } .form-row textarea { width: 300px; height: 180px; } .form-row select[multiple] { width: 300px; height: 180px; } form .form-row p { padding-left:0; font-size:11px; } diff --git a/ipf/admin/templates/admin/items.html b/ipf/admin/templates/admin/items.html index 3227943..2cd88b3 100644 --- a/ipf/admin/templates/admin/items.html +++ b/ipf/admin/templates/admin/items.html @@ -7,7 +7,7 @@ {block bodyclass}change-list{/block} -{block breadcrumbs}{/block} +{block breadcrumbs}{/block} {block content}
diff --git a/ipf/form/widget/selectinput.php b/ipf/form/widget/selectinput.php index b39a12f..10ccebe 100644 --- a/ipf/form/widget/selectinput.php +++ b/ipf/form/widget/selectinput.php @@ -15,17 +15,15 @@ class IPF_Form_Widget_SelectInput extends IPF_Form_Widget parent::__construct($attrs); } - public function render($name, $value, $extra_attrs=array(), $choices=array()) + public function render($name, $value, $extra_attrs=array()) { - $output = array(); - if ($value === null) { + if ($value === null) $value = ''; - } + $select = Tag::select($this->attrs) ->attrs($extra_attrs) ->attr('name', $name); - $choices = $this->choices + $choices; - foreach ($choices as $option_label => $option_value) { + foreach ($this->choices as $option_label => $option_value) { $select->append(Tag::option() ->attr('value', $option_value) ->toggleAttr('selected', 'selected', $option_value == $value) -- 2.49.0