From: Andrey Kutejko <andy128k@gmail.com>
Date: Sun, 11 Jan 2015 03:12:51 +0000 (+0200)
Subject: fixes on debug error page
X-Git-Tag: 0.6~72
X-Git-Url: https://git.andy128k.dev/?a=commitdiff_plain;h=a8a14e530aa33b3355b23f75174ec58570353aa2;p=ipf.git

fixes on debug error page
---

diff --git a/ipf/error/500_debug.html b/ipf/error/500_debug.html
index 1bc5ac0..2780ae7 100644
--- a/ipf/error/500_debug.html
+++ b/ipf/error/500_debug.html
@@ -22,7 +22,7 @@ $frames = $this->frames($this->exception);
 
     #summary { background: #F50000; padding:20px; height: 100px; color: #ccc; font-weight: bold;  }
     #summary h1 { margin: 0; <?php echo $do_not_overflow ?> }
-    #summary h2 { margin: 10px 0; color: #eee; <?php echo $do_not_overflow ?> }
+    #summary h2 { margin: 10px 0; color: #eee; height: 1.5em; line-height: 1.5em; <?php echo $do_not_overflow ?> }
 
     #sidebar { background:#eee; float: left; width: 260px; margin:0; padding: 0 20px; height: calc(100% - 140px); overflow: auto; border-right: 1px solid #ccc; }
     #sidebar a { display: block; margin: 10px 0; color: #666; text-decoration: none; line-height: 1.5em; border-bottom: 1px dotted #ccc; padding: 10px 0; <?php echo $do_not_overflow ?> }
@@ -33,7 +33,7 @@ $frames = $this->frames($this->exception);
     #content h2 { margin: 20px 0 10px;font-size:200%; }
     #content h3 { margin: 10px 0 5px;font-size:150%; }
 
-    .dump {border: 1px dotted #666;<?php echo $code ?>}
+    .dump {border: 1px dotted #666;padding: 0.5em;<?php echo $code ?>}
 
     table.values { padding: 0;margin:10px 0;border-collapse: collapse;table-layout:fixed;width:100%; }
     table.values th { vertical-align: top; padding: 0.5em 1em 0.5em 0; text-align: left; width:200px; }
@@ -57,6 +57,7 @@ $frames = $this->frames($this->exception);
   <!-- /Summary -->
 
   <div id="sidebar">
+    <a href="#message" title="Error Message">Error Message</a>
     <a href="#request" title="Request">Request</a>
     <a href="#response" title="Response">Response</a>
     <h3>Stacktrace</h3>
@@ -71,6 +72,11 @@ $frames = $this->frames($this->exception);
   </div>
 
   <div id="content">
+    <div id="message">
+      <h2>Error Message</h2>
+      <div class="dump"><?php $this->e($msg) ?></div>
+    </div>
+
     <div id="request">
       <h2>Request</h2>
 
diff --git a/ipf/error/500_debug.php b/ipf/error/500_debug.php
index 58cfc6e..1636efc 100644
--- a/ipf/error/500_debug.php
+++ b/ipf/error/500_debug.php
@@ -82,9 +82,9 @@ class IPF_Server_Error_Page_Debug extends IPF_Error_Page
         $line = $exception->getLine();
         foreach ($exception->getTrace() as $frame) {
             $params = array();
-            if ($frame["function"]) {
+            if (isset($frame["function"])) {
                 try {
-                    if ($frame["class"]) {
+                    if (isset($frame["class"])) {
                         $r = new ReflectionMethod($frame["class"]."::".$frame["function"]);
                     } else {
                         $r = new ReflectionFunction($frame["function"]);