From: Andrey Kutejko <andy128k@gmail.com>
Date: Thu, 25 Dec 2014 22:34:57 +0000 (+0200)
Subject: no static methods in auth app
X-Git-Tag: 0.6~113
X-Git-Url: https://git.andy128k.dev/?a=commitdiff_plain;h=7ed9be89e53246441d6433f1af38c5bbb10809c8;p=ipf.git

no static methods in auth app
---

diff --git a/ipf/admin/app.php b/ipf/admin/app.php
index 976aba0..815555e 100644
--- a/ipf/admin/app.php
+++ b/ipf/admin/app.php
@@ -109,7 +109,7 @@ class IPF_Admin_App extends IPF_Application
         if (count(array_diff($requiredPermissions, $component->getPerms($request))))
             return false;
 
-        if ($request->user->is_superuser || !\IPF_Auth_App::ArePermissionsEnabled())
+        if ($request->user->is_superuser || !\PFF\Container::auth()->arePermissionsEnabled())
             return true;
 
         $authPermissions = F::bind('array_map',
diff --git a/ipf/auth/admin.php b/ipf/auth/admin.php
index 87b9c5a..a0c39b1 100644
--- a/ipf/auth/admin.php
+++ b/ipf/auth/admin.php
@@ -89,7 +89,7 @@ class UserForm extends \IPF_ObjectForm
         }
 
         $permissions = array('is_active', 'is_staff', 'is_superuser');
-        if (\IPF_Auth_App::ArePermissionsEnabled()) {
+        if (\PFF\Container::auth()->arePermissionsEnabled()) {
             $permissions[] = 'permissions';
             $permissions[] = 'roles';
 
@@ -165,7 +165,7 @@ class AdminUser extends \IPF_Admin_Component
             'is_staff',
             'is_superuser',
         );
-        if (\IPF_Auth_App::ArePermissionsEnabled()) {
+        if ($this->auth_app->arePermissionsEnabled()) {
             $columns[] = 'groups';
         }
         return $columns;
@@ -266,7 +266,7 @@ class RoleForm extends \IPF_ObjectForm
             'max_length' => 255,
         ));
 
-        if (\IPF_Auth_App::ArePermissionsEnabled()) {
+        if (\PFF\Container::auth()->arePermissionsEnabled()) {
             $this->fields['permissions'] = new \IPF_Form_Field_MultipleChoice(array(
                 'label'     => __('Permissions'),
                 'choices'   => permissionChoices(),
@@ -356,7 +356,7 @@ class AdminRole extends \IPF_Admin_Component
     public function slug() { return 'role'; }
 }
 
-if (\IPF_Auth_App::ArePermissionsEnabled()) {
+if (\PFF\Container::auth()->arePermissionsEnabled()) {
     return array(
         'IPF\Auth\Admin\AdminUser',
         'IPF\Auth\Admin\AdminRole',
diff --git a/ipf/auth/app.php b/ipf/auth/app.php
index 4626c1e..f4121b3 100644
--- a/ipf/auth/app.php
+++ b/ipf/auth/app.php
@@ -55,16 +55,16 @@ class IPF_Auth_App extends IPF_Application
         );
     }
 
-    private static $permissionsEnabled = null;
+    private $permissionsEnabled = null;
 
-    static function ArePermissionsEnabled()
+    function arePermissionsEnabled()
     {
-        if (self::$permissionsEnabled === null)
-            self::$permissionsEnabled = (bool)\PFF\Container::databaseQuery()
+        if ($this->permissionsEnabled === null)
+            $this->permissionsEnabled = (bool)\PFF\Container::databaseQuery()
                 ->from('auth_permission')
                 ->select('COUNT(1)')
                 ->fetchColumn();
-        return self::$permissionsEnabled;
+        return $this->permissionsEnabled;
     }
 
     public function commands()